johnperry
commented
7 years ago Please send me your source file for DicomDifferenceLogger.
I think what you did is correct.
I think I left the file there so I could see it while I was debugging and then forgot to delete it before the release.
JP
From: Sean Doyle Sent: Wednesday, December 07, 2016 10:11 AM To: johnperry/CTP Subject: [johnperry/CTP] DicomDifferenceLogger leaves large amount of temp files (#14)
Hi -
I've had an issue with many (> 100K) temp files left in the DicomDifferenceFolder temp directory. If I understand the code correctly it just needed the temp file deleted after the file was enqueued:
$ git diff ctp/stdstages/DicomDifferenceLogger.java diff --git a/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java b/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java index 23f31d7..7cb3325 100644 --- a/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java +++ b/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java @@ -187,6 +187,8 @@ public class DicomDifferenceLogger extends AbstractPipelineStage implements Expo if (quarantine != null) quarantine.insertCopy(fileObject); logger.warn(name+": Unable to enter difference object in the export queue"); }
- logger.debug(name+": about to delete file " + entryFile.getAbsolutePath());
- entryFile.delete(); } This seems to work well for me - but if it's a bad fix please let me know.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
seandoyle
Hi -
I've had an issue with many (> 100K) temp files left in the DicomDifferenceFolder temp directory. If I understand the code correctly it just needed the temp file deleted after the file was enqueued:
$ git diff ctp/stdstages/DicomDifferenceLogger.java diff --git a/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java b/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java index 23f31d7..7cb3325 100644 --- a/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java +++ b/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java @@ -187,6 +187,8 @@ public class DicomDifferenceLogger extends AbstractPipelineStage implements Expo if (quarantine != null) quarantine.insertCopy(fileObject); logger.warn(name+": Unable to enter difference object in the export queue"); } + logger.debug(name+": about to delete file " + entryFile.getAbsolutePath()); + entryFile.delete(); } This seems to work well for me - but if it's a bad fix please let me know.