Open seandoyle opened 7 years ago
Please send me your source file for DicomDifferenceLogger.
I think what you did is correct.
I think I left the file there so I could see it while I was debugging and then forgot to delete it before the release.
JP
From: Sean Doyle Sent: Wednesday, December 07, 2016 10:11 AM To: johnperry/CTP Subject: [johnperry/CTP] DicomDifferenceLogger leaves large amount of temp files (#14)
Hi -
I've had an issue with many (> 100K) temp files left in the DicomDifferenceFolder temp directory. If I understand the code correctly it just needed the temp file deleted after the file was enqueued:
$ git diff ctp/stdstages/DicomDifferenceLogger.java diff --git a/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java b/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java index 23f31d7..7cb3325 100644 --- a/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java +++ b/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java @@ -187,6 +187,8 @@ public class DicomDifferenceLogger extends AbstractPipelineStage implements Expo if (quarantine != null) quarantine.insertCopy(fileObject); logger.warn(name+": Unable to enter difference object in the export queue"); }
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
From: John Perry [mailto:notifications@github.com] Sent: Wednesday, December 07, 2016 5:34 PM To: johnperry/CTP Cc: Doyle, Sean W.; Author Subject: Re: [johnperry/CTP] DicomDifferenceLogger leaves large amount of temp files (#14)
Please send me your source file for DicomDifferenceLogger.
I think what you did is correct.
I think I left the file there so I could see it while I was debugging and then forgot to delete it before the release.
JP
From: Sean Doyle Sent: Wednesday, December 07, 2016 10:11 AM To: johnperry/CTP Subject: [johnperry/CTP] DicomDifferenceLogger leaves large amount of temp files (#14)
Hi -
I've had an issue with many (> 100K) temp files left in the DicomDifferenceFolder temp directory. If I understand the code correctly it just needed the temp file deleted after the file was enqueued:
$ git diff ctp/stdstages/DicomDifferenceLogger.java diff --git a/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java b/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java index 23f31d7..7cb3325 100644 --- a/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java +++ b/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java @@ -187,6 +187,8 @@ public class DicomDifferenceLogger extends AbstractPipelineStage implements Expo if (quarantine != null) quarantine.insertCopy(fileObject); logger.warn(name+": Unable to enter difference object in the export queue"); }
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/johnperry/CTP/issues/14#issuecomment-265595184, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAfmwHtAhF_bQUQKbXNbxS8XgoQ5Ptg1ks5rFzRigaJpZM4LGxse.
The information in this e-mail is intended only for the person to whom it is addressed. If you believe this e-mail was sent to you in error and the e-mail contains patient information, please contact the Partners Compliance HelpLine at http://www.partners.org/complianceline . If the e-mail was sent to you in error but does not contain patient information, please contact the sender and properly dispose of the e-mail.
Did you intend to send the DicomDifferenceLogger code? Nothing was attached.
JP
From: Sean Doyle Sent: Thursday, December 08, 2016 7:00 AM To: johnperry/CTP Cc: John Perry ; Comment Subject: Re: [johnperry/CTP] DicomDifferenceLogger leaves large amount of temp files (#14)
From: John Perry [mailto:notifications@github.com] Sent: Wednesday, December 07, 2016 5:34 PM To: johnperry/CTP Cc: Doyle, Sean W.; Author Subject: Re: [johnperry/CTP] DicomDifferenceLogger leaves large amount of temp files (#14)
Please send me your source file for DicomDifferenceLogger.
I think what you did is correct.
I think I left the file there so I could see it while I was debugging and then forgot to delete it before the release.
JP
From: Sean Doyle Sent: Wednesday, December 07, 2016 10:11 AM To: johnperry/CTP Subject: [johnperry/CTP] DicomDifferenceLogger leaves large amount of temp files (#14)
Hi -
I've had an issue with many (> 100K) temp files left in the DicomDifferenceFolder temp directory. If I understand the code correctly it just needed the temp file deleted after the file was enqueued:
$ git diff ctp/stdstages/DicomDifferenceLogger.java diff --git a/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java b/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java index 23f31d7..7cb3325 100644 --- a/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java +++ b/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java @@ -187,6 +187,8 @@ public class DicomDifferenceLogger extends AbstractPipelineStage implements Expo if (quarantine != null) quarantine.insertCopy(fileObject); logger.warn(name+": Unable to enter difference object in the export queue"); }
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/johnperry/CTP/issues/14#issuecomment-265595184, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAfmwHtAhF_bQUQKbXNbxS8XgoQ5Ptg1ks5rFzRigaJpZM4LGxse.
The information in this e-mail is intended only for the person to whom it is addressed. If you believe this e-mail was sent to you in error and the e-mail contains patient information, please contact the Partners Compliance HelpLine at http://www.partners.org/complianceline . If the e-mail was sent to you in error but does not contain patient information, please contact the sender and properly dispose of the e-mail.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
Hm.. I did the drag and drop thing and hit the send key. This was done the old fashioned way by selecting the file :-).
Thanks
From: John Perry [mailto:notifications@github.com] Sent: Thursday, December 08, 2016 9:21 AM To: johnperry/CTP Cc: Doyle, Sean W.; Author Subject: Re: [johnperry/CTP] DicomDifferenceLogger leaves large amount of temp files (#14)
Did you intend to send the DicomDifferenceLogger code? Nothing was attached.
JP
From: Sean Doyle Sent: Thursday, December 08, 2016 7:00 AM To: johnperry/CTP Cc: John Perry ; Comment Subject: Re: [johnperry/CTP] DicomDifferenceLogger leaves large amount of temp files (#14)
From: John Perry [mailto:notifications@github.com] Sent: Wednesday, December 07, 2016 5:34 PM To: johnperry/CTP Cc: Doyle, Sean W.; Author Subject: Re: [johnperry/CTP] DicomDifferenceLogger leaves large amount of temp files (#14)
Please send me your source file for DicomDifferenceLogger.
I think what you did is correct.
I think I left the file there so I could see it while I was debugging and then forgot to delete it before the release.
JP
From: Sean Doyle Sent: Wednesday, December 07, 2016 10:11 AM To: johnperry/CTP Subject: [johnperry/CTP] DicomDifferenceLogger leaves large amount of temp files (#14)
Hi -
I've had an issue with many (> 100K) temp files left in the DicomDifferenceFolder temp directory. If I understand the code correctly it just needed the temp file deleted after the file was enqueued:
$ git diff ctp/stdstages/DicomDifferenceLogger.java diff --git a/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java b/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java index 23f31d7..7cb3325 100644 --- a/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java +++ b/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java @@ -187,6 +187,8 @@ public class DicomDifferenceLogger extends AbstractPipelineStage implements Expo if (quarantine != null) quarantine.insertCopy(fileObject); logger.warn(name+": Unable to enter difference object in the export queue"); }
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/johnperry/CTP/issues/14#issuecomment-265595184, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAfmwHtAhF_bQUQKbXNbxS8XgoQ5Ptg1ks5rFzRigaJpZM4LGxse.
The information in this e-mail is intended only for the person to whom it is addressed. If you believe this e-mail was sent to you in error and the e-mail contains patient information, please contact the Partners Compliance HelpLine at http://www.partners.org/complianceline . If the e-mail was sent to you in error but does not contain patient information, please contact the sender and properly dispose of the e-mail.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/johnperry/CTP/issues/14#issuecomment-265750744, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAfmwLu1GUZFmQHIMbyx3GshMWtKlFZXks5rGBJRgaJpZM4LGxse.
I can't find the attachment. Please send it to my direct email account (johnperry@dls.net).
Thanks... JP
From: Sean Doyle Sent: Thursday, December 08, 2016 10:22 AM To: johnperry/CTP Cc: John Perry ; Comment Subject: Re: [johnperry/CTP] DicomDifferenceLogger leaves large amount of temp files (#14)
Hm.. I did the drag and drop thing and hit the send key. This was done the old fashioned way by selecting the file :-).
Thanks
From: John Perry [mailto:notifications@github.com] Sent: Thursday, December 08, 2016 9:21 AM To: johnperry/CTP Cc: Doyle, Sean W.; Author Subject: Re: [johnperry/CTP] DicomDifferenceLogger leaves large amount of temp files (#14)
Did you intend to send the DicomDifferenceLogger code? Nothing was attached.
JP
From: Sean Doyle Sent: Thursday, December 08, 2016 7:00 AM To: johnperry/CTP Cc: John Perry ; Comment Subject: Re: [johnperry/CTP] DicomDifferenceLogger leaves large amount of temp files (#14)
From: John Perry [mailto:notifications@github.com] Sent: Wednesday, December 07, 2016 5:34 PM To: johnperry/CTP Cc: Doyle, Sean W.; Author Subject: Re: [johnperry/CTP] DicomDifferenceLogger leaves large amount of temp files (#14)
Please send me your source file for DicomDifferenceLogger.
I think what you did is correct.
I think I left the file there so I could see it while I was debugging and then forgot to delete it before the release.
JP
From: Sean Doyle Sent: Wednesday, December 07, 2016 10:11 AM To: johnperry/CTP Subject: [johnperry/CTP] DicomDifferenceLogger leaves large amount of temp files (#14)
Hi -
I've had an issue with many (> 100K) temp files left in the DicomDifferenceFolder temp directory. If I understand the code correctly it just needed the temp file deleted after the file was enqueued:
$ git diff ctp/stdstages/DicomDifferenceLogger.java diff --git a/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java b/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java index 23f31d7..7cb3325 100644 --- a/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java +++ b/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java @@ -187,6 +187,8 @@ public class DicomDifferenceLogger extends AbstractPipelineStage implements Expo if (quarantine != null) quarantine.insertCopy(fileObject); logger.warn(name+": Unable to enter difference object in the export queue"); }
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/johnperry/CTP/issues/14#issuecomment-265595184, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAfmwHtAhF_bQUQKbXNbxS8XgoQ5Ptg1ks5rFzRigaJpZM4LGxse.
The information in this e-mail is intended only for the person to whom it is addressed. If you believe this e-mail was sent to you in error and the e-mail contains patient information, please contact the Partners Compliance HelpLine at http://www.partners.org/complianceline . If the e-mail was sent to you in error but does not contain patient information, please contact the sender and properly dispose of the e-mail.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/johnperry/CTP/issues/14#issuecomment-265750744, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAfmwLu1GUZFmQHIMbyx3GshMWtKlFZXks5rGBJRgaJpZM4LGxse.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
Hi -
I've had an issue with many (> 100K) temp files left in the DicomDifferenceFolder temp directory. If I understand the code correctly it just needed the temp file deleted after the file was enqueued:
$ git diff ctp/stdstages/DicomDifferenceLogger.java diff --git a/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java b/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java index 23f31d7..7cb3325 100644 --- a/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java +++ b/source/java/org/rsna/ctp/stdstages/DicomDifferenceLogger.java @@ -187,6 +187,8 @@ public class DicomDifferenceLogger extends AbstractPipelineStage implements Expo if (quarantine != null) quarantine.insertCopy(fileObject); logger.warn(name+": Unable to enter difference object in the export queue"); } + logger.debug(name+": about to delete file " + entryFile.getAbsolutePath()); + entryFile.delete(); } This seems to work well for me - but if it's a bad fix please let me know.