search

johnperry / CTP

Clinical Trial Processor
http://mircwiki.rsna.org/index.php?title=CTP_Articles
65 stars 55 forks source link

Fix acceptDuplicates=no of DirectoryStorageService #3

Closed philippsteffan closed 10 years ago

philippsteffan commented 10 years ago

Configuration acceptDuplicates=no of DirectoryStorageService creates .partial duplicates. If the destination file of renameTo() exists, the behaviour is undefined (On Windows renameTo() fails).

Due to this acceptDuplicates=no is broken (at least on Windows), because DirectoryStorageService will create duplicates (savedFile and tempFile).

johnperry commented 10 years ago

Steffan:

Nice catch.

I fixed the problem, but I can’t make a release until next week when I finish the new quarantine manager.

JP

From: philippsteffan Sent: Friday, May 23, 2014 8:03 AM To: johnperry/CTP Subject: [CTP] Fix acceptDuplicates=no of DirectoryStorageService (#3)

Configuration acceptDuplicates=no of DirectoryStorageService creates .partial duplicates. If the destination file of renameTo() exists, the behaviour is undefined (On Windows renameTo() fails).

Due to this acceptDuplicates=no is broken (at least on Windows), because DirectoryStorageService will create duplicates (savedFile and tempFile).

You can merge this Pull Request by running git pull https://github.com/philippsteffan/CTP masterOr view, comment on, or merge it at:

https://github.com/johnperry/CTP/pull/3

Commit Summary a.. Fix acceptDuplicates=no of DirectoryStorageService File Changes a.. M source/java/org/rsna/ctp/stdstages/DirectoryStorageService.java (3) Patch Links: a.. https://github.com/johnperry/CTP/pull/3.patch b.. https://github.com/johnperry/CTP/pull/3.diff — Reply to this email directly or view it on GitHub.