search

johnpierson / RhythmForDynamo

A collection of nodes for use in Dynamo with Revit.
BSD 3-Clause "New" or "Revised" License
108 stars 25 forks source link

Upgrade SDK Style #56

Closed chuongmep closed 10 months ago

chuongmep commented 10 months ago
johnpierson commented 10 months ago

Thanks so much @chuongmep ! Let me get this merged. For future pull requests can you hang on until I get the branch “Version Fixing” merged?

chuongmep commented 10 months ago

Hi @johnpierson , let merge your pull request first, I will modify after that

johnpierson commented 10 months ago

Much appreciated!

On Fri, Aug 11, 2023 at 8:35 PM Chuong Ho @.***> wrote:

Hi @johnpierson https://github.com/johnpierson , let merge your pull request first, I will modify after that

— Reply to this email directly, view it on GitHub https://github.com/johnpierson/RhythmForDynamo/pull/56#issuecomment-1675634413, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYD5VDFNCMD55DIOI7YBS3XU3TVRANCNFSM6AAAAAA3NSVVJE . You are receiving this because you were mentioned.Message ID: @.***>

johnpierson commented 10 months ago

Created a dev branch and changed it here for you!

chuongmep commented 10 months ago

Nice, let me do for next step.

johnpierson commented 10 months ago

One thing I am looking for here, is for the end goal to give me a folder for each Revit version (because I will still be using the package manager). Is that doable with this setup?

chuongmep commented 10 months ago

@johnpierson , yes, it will support automation generate to Dynamo version match with Revit version, you can upload to Dynamo package manager if you want.

johnpierson commented 10 months ago

Very awesome. Thank you. Looking forward to seeing the changes! Looking through your OpenMEP repo now to get an idea, awesome stuff.

On Fri, Aug 11, 2023 at 9:05 PM Chuong Ho @.***> wrote:

@johnpierson https://github.com/johnpierson , yes, it will support automation generate to Dynamo version match with Revit version, you can upload to Dynamo package manager if you want.

— Reply to this email directly, view it on GitHub https://github.com/johnpierson/RhythmForDynamo/pull/56#issuecomment-1675646875, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYD5VELSM7MD4N4VMWXDFLXU3XI7ANCNFSM6AAAAAA3NSVVJE . You are receiving this because you were mentioned.Message ID: @.***>

chuongmep commented 10 months ago

@johnpierson this one not include in nuget online ? image

johnpierson commented 10 months ago

Oh, it isn't. But I should include that as well. lets leave the program file references for now?

On Fri, Aug 11, 2023 at 9:30 PM Chuong Ho @.***> wrote:

@johnpierson https://github.com/johnpierson this one not include in nuget online ? [image: image] https://user-images.githubusercontent.com/31106432/260195887-82917298-11e4-465a-90f1-7b84ad77f746.png

— Reply to this email directly, view it on GitHub https://github.com/johnpierson/RhythmForDynamo/pull/56#issuecomment-1675656785, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYD5VG43HN7TEACMBX53M3XU32HHANCNFSM6AAAAAA3NSVVJE . You are receiving this because you were mentioned.Message ID: @.***>

chuongmep commented 10 months ago

May be do it temp first, I will consider publish nuget to support nuget online.

chuongmep commented 10 months ago

@johnpierson did you have old version ? I need more than one version of 2024 but now I just install 2024 in my computer, can help me assitance that ?

johnpierson commented 10 months ago

I only have 2024.1

On Fri, Aug 11, 2023 at 10:07 PM Chuong Ho @.***> wrote:

@johnpierson https://github.com/johnpierson did you have old version ? I need more than one version of 2024 but now I just install 2024 in my computer, can help me assitance that ?

— Reply to this email directly, view it on GitHub https://github.com/johnpierson/RhythmForDynamo/pull/56#issuecomment-1675674208, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYD5VFWETUJUMNJU65LXH3XU36PLANCNFSM6AAAAAA3NSVVJE . You are receiving this because you were mentioned.Message ID: @.***>

chuongmep commented 10 months ago

Wow, let me create new pull request support latest version first , include on configuration, and after that we will need some guy volunter add more dll of old version to support full from 20 to 24.1

johnpierson commented 10 months ago

If you want to hold on for now, I can get those added this next week. I don't want you to do a bunch of extra work, when I am still moving things.

On Fri, Aug 11, 2023 at 10:11 PM Chuong Ho @.***> wrote:

Wow, let me create new pull request support latest version first , include on configuration, and after that we will need some guy volunter add more dll of old version to support full from 20 to 24.1

— Reply to this email directly, view it on GitHub https://github.com/johnpierson/RhythmForDynamo/pull/56#issuecomment-1675677764, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYD5VCG2VQNARJGKCJUO53XU366RANCNFSM6AAAAAA3NSVVJE . You are receiving this because you were mentioned.Message ID: @.***>

chuongmep commented 10 months ago

For sure, We can colaborate after I create next pull request .