search

johnpierson / RhythmForDynamo

A collection of nodes for use in Dynamo with Revit.
BSD 3-Clause "New" or "Revised" License
108 stars 25 forks source link

Rhythm version fixing #57

Closed johnpierson closed 10 months ago

johnpierson commented 10 months ago

In progress branch for making Rhythm multi version Compatible.

chuongmep commented 10 months ago

Hi @johnpierson , I checked with your pull request, It is follow with old process, can we consider use new SDK style ? I will do support for process Automation CI/CD ?

johnpierson commented 10 months ago

New SDK sounds fine to me! I can go ahead and merge mine if you want to revise it after ?

On Fri, Aug 11, 2023 at 8:40 PM Chuong Ho @.***> wrote:

Hi @johnpierson https://github.com/johnpierson , I checked with your pull request, It is follow with old process, can we consider use new SDK style ? I will do support for process Automation CI/CD ?

— Reply to this email directly, view it on GitHub https://github.com/johnpierson/RhythmForDynamo/pull/57#issuecomment-1675636430, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYD5VBQ7AIVJHWAPSR7PPLXU3UK5ANCNFSM6AAAAAA3NSY5XQ . You are receiving this because you were mentioned.Message ID: @.***>

chuongmep commented 10 months ago

Okay, let help me create new branch dev, and I will create pull request to this branch first, after that, if you feel like process, we will merge to master branch.

johnpierson commented 10 months ago

Awesome. Let me merge these changes to master. Some background: rhythm now loads Revit nodes on the fly with a view extension. But I did change to shared projects with specific versions as well.

On Fri, Aug 11, 2023 at 8:43 PM Chuong Ho @.***> wrote:

Okay, let create new branch dev, and I will create pull request to this branch first, after that, if you feel like process, we will merge to master branch.

— Reply to this email directly, view it on GitHub https://github.com/johnpierson/RhythmForDynamo/pull/57#issuecomment-1675638252, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYD5VE2LMMXDGOAH34O22DXU3UUXANCNFSM6AAAAAA3NSY5XQ . You are receiving this because you were mentioned.Message ID: @.***>

chuongmep commented 10 months ago

" But I did change to shared projects with specific versions as well." No need that @johnpierson , I will help for that with new SDK Style

johnpierson commented 10 months ago

Hmm, I’ll have to review the PR pretty thoroughly then. As that’s all new to me.

On Fri, Aug 11, 2023 at 8:45 PM Chuong Ho @.***> wrote:

" But I did change to shared projects with specific versions as well." No need that @johnpierson https://github.com/johnpierson , I will help for that with new SDK Style

— Reply to this email directly, view it on GitHub https://github.com/johnpierson/RhythmForDynamo/pull/57#issuecomment-1675639286, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYD5VDFPBAUUBMVHJ47Z6TXU3U5ZANCNFSM6AAAAAA3NSY5XQ . You are receiving this because you were mentioned.Message ID: @.***>

chuongmep commented 10 months ago

It will be easier than that @johnpierson , I will create all documentation to follow after create another pull request to help you can run with all version of Revit

chuongmep commented 10 months ago

Can you create new branch dev, I just create new pull request change to this branch and review first, before this pull request merge to master, this is my target :

johnpierson commented 10 months ago

That works for me! And I will leave my view extension and extension work on the other branch for now and cherry pick it later.

On Fri, Aug 11, 2023 at 8:53 PM Chuong Ho @.***> wrote:

Can you create new branch dev, I just create new pull request change to this branch and review first, before this pull request merge to master, this is my target :

  • you help me create new branch dev
  • I change pull request new SDK style to dev branch
  • I create custom version configuration for project
  • I create CI/CD process automation for package
  • I create new pull request to dev branch
  • You compare with current process before this pull request merge to master, if it ok, close this pull request and merge branch dev to master, if it not good, merge your pull request.
  • Done

— Reply to this email directly, view it on GitHub https://github.com/johnpierson/RhythmForDynamo/pull/57#issuecomment-1675642488, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYD5VG22ENSCUJQIVWYFPDXU3VZTANCNFSM6AAAAAA3NSY5XQ . You are receiving this because you were mentioned.Message ID: @.***>