johnpierson / RhythmForDynamo

A collection of nodes for use in Dynamo with Revit.
BSD 3-Clause "New" or "Revised" License
108 stars 25 forks source link

Fix workflow #63

Closed chuongmep closed 10 months ago

chuongmep commented 10 months ago

Please try merge this workflow, if it still wrong, please delete your dev branch and create clone new dev from my branch with branch name is vcho

johnpierson commented 10 months ago

I believe it worked. I just need to bring it to main for it to fully finish

johnpierson commented 10 months ago

Do you use Visual Studio @chuongmep ? I am having trouble understanding how to tag a commit properly for the build

johnpierson commented 10 months ago

So it is building, I just suck at adding tags.

Is there a way to change how we version it? Or do I need to learn how to create tags while committing

chuongmep commented 10 months ago

Do you use Visual Studio @chuongmep ? I am having trouble understanding how to tag a commit properly for the build

Yes, I'm using both Visual Studio and Rider to maintain code.

chuongmep commented 10 months ago

You mean is you want to create tag for release version ?

johnpierson commented 10 months ago

Yes

On Wed, Aug 16, 2023 at 6:02 PM Chuong Ho @.***> wrote:

You mean is you want to create tag for release version ?

— Reply to this email directly, view it on GitHub https://github.com/johnpierson/RhythmForDynamo/pull/63#issuecomment-1681415730, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYD5VHQBUZOCNVZ5OMT5FTXVVNSBANCNFSM6AAAAAA3SWLTHE . You are receiving this because you modified the open/close state.Message ID: @.***>

chuongmep commented 10 months ago

Oh, for create tag to release, it still needs more step and I'm still haven't finished yet, I will help on this weekend, basically it automaton release installer also. Any issue with Visual Studio ?

chuongmep commented 10 months ago

So it is building, I just suck at adding tags.

Is there a way to change how we version it? Or do I need to learn how to create tags while committing

You just need to create tag in changelog version. I will help that.