search

johnpierson / RhythmForDynamo

A collection of nodes for use in Dynamo with Revit.
BSD 3-Clause "New" or "Revised" License
108 stars 25 forks source link

Resolve conflict with new SDK Style , CICD Process #67

Closed chuongmep closed 1 year ago

chuongmep commented 1 year ago

resolve #66 CI/ CD tracking : https://github.com/chuongmep/RhythmForDynamo/actions/runs/5941457678

johnpierson commented 1 year ago

I think your view extension code needs updated from the master @chuongmep

johnpierson commented 1 year ago

@chuongmep nevermind, I will add back the view extension stuff later.

chuongmep commented 1 year ago

I think your view extension code needs updated from the master @chuongmep

Yes I will quickly fix that, the time between US and SG killed me, I saw you merge to master and fix, still confuse about that.

johnpierson commented 1 year ago

No problem. But for reference, I think any future PR needs to be from scratch unfortunately.

On Tue, Aug 22, 2023 at 6:08 PM Chuong Ho @.***> wrote:

I think your view extension code needs updated from the master @chuongmep https://github.com/chuongmep

Yes, the time between US and SG killed me, I saw you merge to master, still confuse about that.

— Reply to this email directly, view it on GitHub https://github.com/johnpierson/RhythmForDynamo/pull/67#issuecomment-1689077677, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYD5VEB5GR364ROHAJTK5TXWVCWRANCNFSM6AAAAAA32FSEOY . You are receiving this because you modified the open/close state.Message ID: @.***>

chuongmep commented 1 year ago

@johnpierson normally, when I work with my code, I push to dev branch, any developer want collaborate they need follow up with that branch, and then if everything work well, code will merge to master. It also work well with your process? I just want confirm to know which branch is latest to avoid unnecessary incidents like this in the future.

johnpierson commented 1 year ago

Let me make a new dev branch based off of master before you move further.

On Tue, Aug 22, 2023 at 6:43 PM Chuong Ho @.***> wrote:

@johnpierson https://github.com/johnpierson normally, when I work with my code, I push to dev branch, any developer want collaborate they need follow up with that branch, and then if everything work well, code will merge to master. It also work well with your process? I just want confirm to know which branch is latest to avoid unnecessary incidents like this in the future.

— Reply to this email directly, view it on GitHub https://github.com/johnpierson/RhythmForDynamo/pull/67#issuecomment-1689100387, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYD5VDUH3H3OBITF7EX63LXWVG37ANCNFSM6AAAAAA32FSEOY . You are receiving this because you were mentioned.Message ID: @.***>

chuongmep commented 1 year ago

thank you for that @johnpierson , that will help all collaborators who come after me