search

johnpierson / RhythmForDynamo

A collection of nodes for use in Dynamo with Revit.
BSD 3-Clause "New" or "Revised" License
108 stars 25 forks source link

View.Viewport Node Issue #70

Closed joseph-kirkpatrick closed 3 months ago

joseph-kirkpatrick commented 3 months ago

Describe the bug (Please fill in. A clear and concise description of what the bug is. In most cases, it will be helpful if you include journal files.) When adding list to Node it produces a null error in R23 but not R24. Both have the latest Rhythm package. R23 had the new package added and restarted to make sure all dll's have been loaded.

"Warning: View.Viewport operation failed. Method not found: 'Int64 Revit.Elements.Element.get_Id()'. View.Viewport operation failed. Method not found: 'Int64 Revit.Elements.Element.get_id()'.

Steps to Reproduce Feeding the View.Viewport node a list of views returns null,

Expected behavior Typically it just returns the viewport to feed into the rest of the graph

My setup

Dynamo R23 Rhythm

johnpierson commented 3 months ago

fixing now!

joseph-kirkpatrick commented 3 months ago

I was looking into a post from the link below and that does work but, it only results in 1 view port when feeding it the multiple lists. I really need to brush up on my python haha. Thanks for looking into this!! https://forum.dynamobim.com/t/get-view-from-viewport-python/74707/2

johnpierson commented 3 months ago

Yeah, this one is a Dynamo side issue for getting elements by id. (ToDSType())

johnpierson commented 3 months ago

New update will be live in the package manager in about 15 minutes.

joseph-kirkpatrick commented 3 months ago

I'll test it out in R24 and make sure everything is still good in that as well.

joseph-kirkpatrick commented 3 months ago

Confirmed, R23 and R24 both work! :)

johnpierson commented 3 months ago

Great to hear!!

On Tue, Mar 26, 2024 at 11:09 AM StructurallyBrKn @.***> wrote:

Confirmed, R23 and R24 both work! :)

— Reply to this email directly, view it on GitHub https://github.com/johnpierson/RhythmForDynamo/issues/70#issuecomment-2021011196, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYD5VEH24PNDAZDTOGOZQ3Y2GTWJAVCNFSM6AAAAABFJC6YE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRRGAYTCMJZGY . You are receiving this because you modified the open/close state.Message ID: @.***>