Closed Solybum closed 11 months ago
imagesLoaded().done() expects all images to be confirmed loaded before executing, so if for any reason an image to be filled fails to load, no images will get filled.
imagesLoaded().done()
https://github.com/johnpolacek/imagefill.js/blob/4165b58f89028911126e84c6bc39a69431b7b8c5/js/jquery-imagefill.js#L50
If there is no special reason to use done, it should be changed to always, which executes after all images were confirmed loaded or broken. https://github.com/desandro/imagesloaded#always
done
always
imagesLoaded().done()expects all images to be confirmed loaded before executing, so if for any reason an image to be filled fails to load, no images will get filled.https://github.com/johnpolacek/imagefill.js/blob/4165b58f89028911126e84c6bc39a69431b7b8c5/js/jquery-imagefill.js#L50
If there is no special reason to use
done, it should be changed toalways, which executes after all images were confirmed loaded or broken. https://github.com/desandro/imagesloaded#always