search

johnrengelman / shadow

Gradle plugin to create fat/uber JARs, apply file transforms, and relocate packages for applications and libraries. Gradle version of Maven's Shade plugin.
http://imperceptiblethoughts.com/shadow/
Apache License 2.0
3.58k stars 386 forks source link

Support Gradle 8.6 & Java 21 #876

Open Goooler opened 10 months ago

Goooler commented 10 months ago

Migrate things in:

skmedix commented 7 months ago

@johnrengelman Can we get this merged? There's already gradle 8.4, yet we still struggle with gradle 8.3 and java 20

skmedix commented 7 months ago

@Goooler Can you fix jitpack build, so we can use your fork? Currently it's failing https://jitpack.io/com/github/Goooler/shadow/cdc2103ac5/build.log

Goooler commented 7 months ago

@skmedix Published a fork for you, check

Nek-12 commented 5 months ago

@johnrengelman any updates on merging this?

PENEKhun commented 3 months ago

@Goooler The plugin you forked is working fine, thank you so much! And I hope this PR will be merged into Main as soon as possible please. 😭🙏

Grimoren commented 3 months ago

As a workaround(until the next release), this worked for me:

buildscript {
  ext {
    asmAsmVersion = "9.6" // https://gitlab.ow2.org/asm/asm/-/tags
  } 
   configurations {
        classpath {
            resolutionStrategy {
                //in order to handle jackson's higher release version in shadow, this needs to be upgraded to latest.
                force(group: "org.ow2.asm", name: "asm", version: asmAsmVersion)
                force(group: "org.ow2.asm", name: "asm-commons", version: asmAsmVersion)
            }
        }
    }
}
jbartok commented 3 months ago

Hi all. Any chance for this to get merged? We are waiting for the new file permission API to be adopted to deprecate the old one on the Gradle side. Can we assist with anything to speed up the process?

Goooler commented 3 months ago

See #908.

Or you can try my fork.

jbartok commented 2 months ago

Or you can try my fork.

@Goooler, I've tried version 8.1.5 of your fork, but it still uses the old file permission methods we want to deprecate. For example here.

Goooler commented 2 months ago

Ooops, it hasn't been caught. Fell free to send a PR if you want.

jbartok commented 2 months ago

Ooops, it hasn't been caught. Fell free to send a PR if you want.

I'm trying, but I don't seem to have permission to:

❯ git remote -v
origin  git@github.com:Goooler/shadow.git (fetch)
origin  git@github.com:Goooler/shadow.git (push)

❯ git push --set-upstream origin jb/file-permissions/replace-deprecated-api
ERROR: Permission to Goooler/shadow.git denied to jbartok.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
Goooler commented 2 months ago

Inviting you as a collaborator of my repo.