search

johnreva / jquery-lightbox

Automatically exported from code.google.com/p/jquery-lightbox
0 stars 0 forks source link

Some points maybe utils for the plugin #17

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Hi there. Before all, thanks for this fantastic jQuery plugin. I present
here some things that maybe can help you or not, in any case, dont worry.

1º Strings " of " and "Image " are defined with spaces, as you can see,
but, this is not a good idea when you think in the translation of plugin.
In my opinion, the spaces must be used in the code, not in the Strings
variables. A translator view "of" and can translate without problems, but,
if view " of ", maybe forgotten the spaces... and the plugin show the
String wrong.

2º I use the version 0.5 of plugin, and apply <a
href="http://code.google.com/p/jquery-lightbox/issues/detail?id=7"
title="Patch to the plugin in this website">this patch</a> and, I am
surprised: the plugin now run too in Safari 3.1 for Windows. In my previous
test, I try with Opera, Firefox and IE latest versions, and Safari, that
not rule. But, with this patch, good in any case, I see that plugin rules
also in Safari. Maybe you dont know this.

3º Look at this <a
href="http://code.google.com/p/jquery-lightbox/issues/detail?id=16"
title="Plugin submitted issue on this website">submitted issue</a>. Talk
about not valid HTML entities... in fact not is correct, if I not wrong,
the entities are valid, but, maybe the source of plugin needed to save in
UTF-8. I use this charset in the plugin and everything run ok. I think that
is well assumed this charset to the plugin and other related files. Maybe
this is only for my project. Is possible, but I want to say in any case.

Well. It's all for me at this momment. Sorry for my poor english and again
thanks very much for this jQuery plugin. Thanks too for contributors that
submit patchs and issues that help me. Thanks to all!

Original issue reported on code.google.com by davidesp...@gmail.com on 12 Jul 2008 at 10:31

GoogleCodeExporter commented 8 years ago 
Ops... sorry for the HTML links... I think that can be used... sorry.

Original comment by davidesp...@gmail.com on 12 Jul 2008 at 10:32

GoogleCodeExporter commented 8 years ago 
There have been multiple changes made to this project since it's move to 
github, several months ago.  You can 
find the project at http://github.com/krewenki/jquery-lightbox/tree/master .   
Please grab the latest copy from 
github, and if your issue persists, create a new issue there.

Original comment by krewenki on 17 Jun 2009 at 5:01