search

johnrhimawan / pe

0 stars 0 forks source link

UML Diagram Too Complicated #14

Open johnrhimawan opened 2 years ago

johnrhimawan commented 2 years ago

image.png

The UML Diagram goes into too low level details, and as a reader I have to zoom to see it clearly.

soc-se-bot commented 2 years ago

Team's Response

This is actually how the Sort Command executes though. If by low level you meant the model details on the right, the red colour portion, our team feels that it should be included as it is important to show where the sort actually happens, and how the model component links with the logic component.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The sequence diagram provided goes too deep into implementation details. It would be sufficient to show up to this point:

image.png

Since the reader would understand that you are calling the sortPersons(sby) method in the model. There is no need to show the AddressBook and UniquePersonList portion of the sequence diagram. It makes the sequence diagram too low level and going through the PDF I have to zoom my screen to view the sequence diagram's details.