johnrhimawan / pe

0 stars 0 forks source link

Name with Special Characters Not Allowed To Be Input #2

Open johnrhimawan opened 2 years ago

johnrhimawan commented 2 years ago

image.png

As evidenced by the imaged, I am unable to input the name John S/O Doe which prompts me this error message. However, FAP is an application for financial advisors to manage their clients. As such, it would be important for the legal names of the clients to be added accurately to the application. Thus, it should also accept names which include S/O.

soc-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Name does not allow for "/" symbol

As mentioned under functionality bugs, the software does not allow for a person with "s/o" in the name.

image.png

Expected: Allow for "s/o"

Actual: Not allowed

image.png


[original: nus-cs2103-AY2223S1/pe-interim#1532] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The team has decided that the naming convention for this version has only allowed alphabetic characters. However we admit that it is our fault that we did not document this in the user guide.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FeatureFlaw]

Reason for disagreement: This is not a documentation bug. It is clearly explained in the module website that disallowing symbols like / since S/O is used in a person’s name is a FeatureFlaw.

Here is a photo of the description in the module website:

image.png

This is a feature flaw as not allowing the use of symbols in the client's name causes a huge inconvenience to the user (financial advisor) since financial services would certainly require the client's legal name to be used in documents and signings. This means that people with names which include symbols (e.g. having S/O in their name or having a - in their name) would be affected.


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: This is a medium size issue since it causes a rather significant problem to clients with names including symbols such as S/O. Financial advisors would be hindered from using this product as they cannot even add correctly their client's legal name. This will cause a problem when various documents and signings will have to be processed by the financial advisor, which would of course require the legal name of the client.

image.png