Able To Add Duplicate Names

[johnrhimawan]

The command I input:

• First I did add n/John Doe p/12345678 e/johndoe@gmail.com a/Kent Ridge i/100000 m/10000 r/Medium ip/Savings Plan c/CURRENT
• Then I did add n/john doe p/12345678 e/johndoe@gmail.com a/Kent Ridge i/100000 m/10000 r/Medium ip/Savings Plan c/CURRENT

Duplicate detection (e.g., detecting if two persons in the address book are the same) is not trivial; often, detecting only the exact string/value matches is not enough. For example, John Doe and john doe are likely to be the same person.

This is the information provided by the module website. It should be able to determine that John Doe and john doe are duplicates.

[nus-pe-bot]

Team's Response

There can be many John Doe in this world. So our team decided to let it be case sensitive.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

• [x] I disagree

Reason for disagreement: This issue has been clearly documented in the module website. Yes, there can be many John Doe in this world, but the way to differentiate that should not be the to change the capitalization of the name. This also raises the issue of accidentally adding duplicates to the entry John Doe. If it is possible to add an entry for John Doe and john doe with the exact same details, they definitely the same person and should be treated as such. Not resolving this issue would provide complications. Suppose that John Doe wants to decrease his monthly contributions, and then the financial advisor would edit the MONTHLY_CONTRIBUTIONS field of John Doe. However, when sorting by MONTHLY_CONTRIBUTIONS john doe still has the original value, and since all details are the same the financial advisors might assume it to be the real John Doe. A much more apparent issue is the monetary aspect of this that will cause legal complications. There would be a possibility that John Doe is billed twice the size of his monthly contributions since he has 2 entries in the financial advisor planner. If this is the case, the financial advisor might be sued on the account of fraud. The limitations of your duplicate detection are also unclear, with the user guide stating that duplicate checks are only available for name, but the limitations of it being case-sensitive are not mentioned.

Even if the argument was that allowing it to be case-sensitive to accommodate cases of people with the name John Doe, they would likely have different values for the various fields. It is highly unlikely that two people with the name John Doe live in the same house, have the same yearly income, and wish to contribute the same amount of money monthly to this financial service. Even if so, it is impossible that they would have the same phone number and email address at the same time. There is not even a warning that warns the user that they have the same name. This is clearly a bug, and is a feature flaw as shown by the screenshot of the module website.

---