search

johnrhimawan / pe

0 stars 0 forks source link

Able To Add Invalid Phone Number #6

Open johnrhimawan opened 2 years ago

johnrhimawan commented 2 years ago

image.png

Steps to reproduce: add n/Random Guy p/123456789012345678 e/random@gmail a/PGPR i/100000 m/500 r/LOW ip/Savings Plan c/CURRENT

There is no warning when I tried to input a phone number longer than 15 characters, which is the maximum phone number length in the world. This should be detected to avoid cases of inputting invalid phone numbers.

nus-se-script commented 2 years ago

Team's Response

This behaviour does not affect the usage of the app.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: It is longer than the longest phone number possible in the world. It should at least provide a warning that the phone number is invalid. What could happen is that the financial advisor using this application accidentally inputs a wrong phone number longer than 15 and would have no idea he/she did so. This will lead to problems in the future when the client's phone number needs to be used.