johnrom / johnny-site-review

0 stars 0 forks source link

Jon Site QA #1

Closed johnrom closed 11 months ago

johnrom commented 11 months ago

Desktop / All sizes

The desktop experience is pretty much perfect with few imperfections. The columns on project pages work very well and look sleek.

Mobile

The mobile version is a little less polished, which could be fine if you expect most viewers to be on desktop. However, someone designing websites should be primarily considering the mobile form factor for a website (some of our websites have less than 10% desktop usage). Therefore, I'd expect a hiring manager for a web design / ux team to check the mobile side and evaluate your chops there, with bonus points if it is polished.

ℹ️ Nobody cares about tablets.

jprussel commented 11 months ago

Desktop / All sizes

The desktop experience is pretty much perfect with few imperfections. The columns on project pages work very well and look sleek.

  • [x] Link Broken: Broken link fixed.
  • [x] Link Broken: Broken link fixed.
  • [x] Missing whitespace: Whitespace fixed.
  • [x] Years misaligned: Whitespace added between paragraphs so hopefully it doesn't collapse on some browsers.
  • [ ] Design consideration: custom scrollbar is a nice touch, but over dark theme it becomes invisible and is an accessibility issue: That's your browser doing that, there's no scrollbar CSS.

Mobile

The mobile version is a little less polished, which could be fine if you expect most viewers to be on desktop. However, someone designing websites should be primarily considering the mobile form factor for a website (some of our websites have less than 10% desktop usage). Therefore, I'd expect a hiring manager for a web design / ux team to check the mobile side and evaluate your chops there, with bonus points if it is polished.

ℹ️ Nobody cares about tablets.

  • [ ] Mobile nav appears empty. Maybe put the projects here as well, or make Download my Resume more centered to make it appear less empty. May be able to fix with custom CSS but unfortunately that's a Squarespace thing. I wanted to get rid of it entirely but couldn't figure out how without custom CSS.
  • [x] Header hierarchy of the home page footer don't make quite as much sense on mobile. Work Experience, Certifications etc might need more impact: Added more contrast.
  • [x] Can these buttons be side-by-side? Made them full width instead. I thought they looked better that way.
  • [ ] Centered text on mobile is a little dated on project pages Not possible to change without custom CSS.
  • [x] This text alignment feels off, or like it should be a blockquote with a line down the left side: Should be fixed now.
  • [x] Unlike desktop, a lot of the project images feel like run-on sentences on mobile. They could use spacing / some sort of bounding box to make the beginning, end, and focus of images clear. Bonus points for caption text because it's hard to identify what the images are supposed to be. Triple bonus points if you can turn some of the longer series' of images into a slider with arrows / swiping left and right with captions. Fixed spacing issues with images. They should have room between them now.
  • [x] Double video on Foundational Planning: Squarespace deleted all my videos when I upgraded the site (thanks!) Added them back.
johnrom commented 11 months ago

That's your browser doing that, there's no scrollbar CSS.

Weird! Yeah my work PC doesn't have that issue. :shrug:

Changes are approved 😁