General Cleanup - Githubissues

ekaj2 commented 7 years ago

I did some basic refactoring work:

moved some imports to the beginning of files
removed unused imports
removed commented code (when using Git, there is no need to clutter with this)
simplified expressions
- "if a == True" --> "if a"
- "if a > b and c > a" --> "if b < a < c"
removed use of equality operators for comparing None
- "if a != None" --> "if a is not None"
other formatting improvements
- "(a,b, c)" --> "(a, b, c)"
- "if a:do_something()" --> "if a: do_something()"
labeled an unresolved reference that I found
- I am just getting into this code, so I don't feel comfortable with substantial changes yet...

ekaj2 commented 7 years ago

Will do. Does the rest look OK?

ekaj2 commented 7 years ago

Thanks for reviewing: please see changes :-)

johnroper100 commented 7 years ago

Ok, I will have @Peter-Noble take a look at this.

ekaj2 commented 7 years ago

Didn't I already remove the changes for the add-on updater? I may have messed that up, but I thought this commit fixed it.

johnroper100 commented 7 years ago

You did. Peter was just commenting overall.

Peter-Noble commented 7 years ago

Oops... sorry. My bad.

johnroper100 commented 7 years ago

I am still seeing the addon updater stuff

ekaj2 commented 7 years ago

@Peter-Noble @johnroper100

My apologies for the problems with the addon_updater modules; they should be removed now.

ekaj2 commented 7 years ago

@Peter-Noble

From the sounds of it you've been having a look round the code and getting to grips with things a bit so if there is anything I can help with please feel free to ask whatever you want. Is there anything in particular you are interested in adding/improving?

I have been recently doing some work on the modular_tree add-on. As I did there, I would mostly like to be an encouragement to the project and learn a few things. I could implement a .blend auto-saving feature as I did there as a fairly non-obtrusive start. I noticed that right now CM just sends a warning to the user without doing anything. The design I did for modular_tree includes saving of images and texts not just the blend, in addition to error messages.

Not everything has a tooltip, and there are no links to the documentation. I could add that as I did for the tree add-on.

Leave it better than you found it!

I love doing this :-) I will try to work on refactoring when I come across sections of code that could use it.

Does this sound reasonable? Any suggestions for what I could work on?

johnroper100 commented 7 years ago

This sounds awesome!

Peter-Noble commented 7 years ago

Great, sounds good! If you ever want to try anything else then you could checkout this: https://github.com/johnroper100/CrowdMaster/projects/7 I'll try and keep it up to date but if there isn't enough on there then feel free to ask about anything else you want to do.

johnroper100 commented 7 years ago

@ekaj2 Can I envite you to the CrowdMaster developers slack? If so, I need an email. If you don't want to post it here, you can send me an email at crowdmaster@jmroper.com

ekaj2 commented 7 years ago

Sorry if this is a stupid question, but what exactly is that?

johnroper100 commented 7 years ago

It is what we use for contact and messaging among the developers. https://slack.com/

johnroper100 / CrowdMaster

General Cleanup #17