johnroper100 / CrowdMaster

Crowd Simulation for the Masses
http://crowdmaster.org
GNU General Public License v3.0
133 stars 24 forks source link

UI: Zero and Fake users not displayed correctly in Sim and Gen datablock in node editor menu bar. #29

Closed axb2035 closed 7 years ago

axb2035 commented 7 years ago

Current behavior (both Sim and Gen exhibit this behavior):

  1. When a datablock is unlinked using the X button the "0" character does not appear next to item in the browse node tree list of datablock. If you save the file, exit and then reopen it will display correctly. However, if you link and unlink and again the "0" will not appear.
  2. When adding a Fake using the F button user the number "2" does not appear in the datablock info to indicate there is more than one user linked. If you move to another node tree and then back it will display correctly.

Expected behavior:

  1. If no users are linked then "0" should always appear next to the noodle name in the browse node tree list of datablock
  2. When a fake user is added the number "2" appears to indicate there is more than one user linked.

NOTE: On face value it looks like Gen and Sim noodles are saved when the even if no users are linked when no zero is displayed as the User count is not being reduced (note I believe this can lead to noodles disappearing unexpectedly... see next Issue). Most datablocks are purged when the session ends (I believe actions may be an exception). If the system is meant to be designed like this the do you need the Fake user option all all?

To reproduce 1 - 0 not appearing. Example is Gen but Sim acts the same way: Step 1: Create a new Gen noodle. Unlink the noodle by press in the X button. Bring up the browse node tree list of datablock. The "0" is missing.

image

To reproduce 2 - Fake user not being added to displayed user count. Step 1: Create a new Gen node. Press the F button. No change - compare with snapshot from a material with fake user added.

image

image