search

johnsmeeth / opengse

Automatically exported from code.google.com/p/opengse
Apache License 2.0
0 stars 0 forks source link

Process: criteria for code submission #8

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
We've had some tension lately as developers (ok, Mike and I) have gone back
and forth:

"You broke my test!"
"What do you mean?  Your test never worked in the first place!"
"Yes it did!"
"Not on my machine!"
"Well, your machine must be screwed up!"
"No, your machine is screwed up!"
"You should have checked with me before you did that!"
"No, *you* should have checked with *me* before *you* did that!"
etc.

So...how can we move forward without these conflicts?  

What's our presubmit criteria?  What tests must be run before checking in?
 And do we want to allow roll-backs when a change breaks something?  Do we
want to enforce code reviews?  

We currently lack a working process, and we have different ideas about what
that process should be.

As a straw man, we have two separate continuous builds at:
  http://opengse.euw.corp.google.com:8000

(One is built by Maven and one is built by Ant, both under Java 5.)  

Do we wish to take the bold step of saying that any change that breaks
either of those builds should either be "claimed" by the reviewer and fixed
or rolled back?

Original issue reported on code.google.com by Mickey.K...@gmail.com on 28 Jul 2008 at 9:16

GoogleCodeExporter commented 8 years ago

Original comment by Mickey.K...@gmail.com on 29 Jul 2008 at 9:33

GoogleCodeExporter commented 8 years ago 
The tests have been broken out into unit and system tests. The system tests are
generic and can be deployed on any servlet engine which supports WAR files.

The unit tests are specific to the reference servlet engine and are invoked by 
AllTests.

Previously, unit and system tests were mixed together and did not run when 
invoked by
ant (classloader issues) but did run when invoked via intellij.

The current procedure now for accepting patches to the reference servlet engine 
is:
1) A system test which reveals the defect in minigse must be submitted first
2) A patch is applied to the minigse codebase which fixes the problem exposed 
by 1)

Original comment by mike.c.j...@gmail.com on 9 Oct 2008 at 3:42