Closed alex4321 closed 1 year ago
@winglian what do you think? I don't know is that reasonable at all to make such a patch if the new triton version are going to work correctly. But not the currently published ones.
Sounds good to me. It's a small enough fix that's a good workaround until triton is ready
Than I guess I may tag @johnsmith0031 to merge it into pip branch? (Don't know how github right system works with PRs when we're talking about a branches within one repository instead of forks)
Thanks! I'll merge it into both main and pip branch.
Hi. I made a bugfix for the issue I mentioned here: https://github.com/johnsmith0031/alpaca_lora_4bit/issues/101
TL;DR; despite the latest github triton
do_bench
function code have quantiles/percentiles setted to None by default - the versions which is currently available through pypi (up to2.0.0.post1
) havepercentiles=(0.5, 0.2, 0.8)
which causes the following code to break:because instead of float numbers the
timings
dict is filled with tuples (for 0.5/0.2/0.8 percentile).