search

johnsmith0031 / alpaca_lora_4bit

MIT License
533 stars 84 forks source link

Use PyPI versions of dependencies #133

Closed alex4321 closed 1 year ago

alex4321 commented 1 year ago

Since the initial dependency on github's transformers main-branch version and specific commit inside peft:

git+https://github.com/huggingface/peft.git@70af02a2bca5a63921790036b2c9430edf4037e2
git+https://github.com/huggingface/transformers.git

were set up a long ago - I tried to check if pypi stable versions works fine now.

It seems so in cases I tried, so maybe we do not need do depend on old specific peft commit and non-stable transformers version anymore?

p.s. I guess I would also make some autotests later, to check such an ideas better than just "well, I runned some of my inference and finetuning scripts depending on this stuff". Anyway, that's offtopic regards this specific PR.

johnsmith0031 commented 1 year ago

Thanks! I think we can shift the dependency to current one.