johnsmith0031 / alpaca_lora_4bit

MIT License
533 stars 84 forks source link

Why lora support is only for simple lora with only q_proj and v_proj ? #155

Open XpracticeYSKM opened 5 months ago

XpracticeYSKM commented 5 months ago

Thanks for your awesome repo!

I notice that you mentioned "lora support is only for simple lora with only q_proj and v_proj", and I wonder whether I can apply lora with other modules like k_proj、o_proj、donw_proj and so on.

It seems the implementation is not only designed for “q_proj and v_proj“, so why lora support is only for simple lora with only q_proj and v_proj ?

johnsmith0031 commented 5 months ago

You can add more modules in training scripts if you want add something else like k_proj "lora support is only for simple lora with only q_proj and v_proj" is about the optimization for inference in this repo, but is already very slow now. It is recommended to use this repo for training and exllamav2 (fastest for now) for inference.