search

johnson-c / ColRadPy

Collisional-radiative python solver
Other
27 stars 10 forks source link

Incorrect Units for PECs on y-axis in .plot_pec_sticks([0],[0],[0]) #29

Open stinkymonke opened 2 weeks ago

stinkymonke commented 2 weeks ago

The y-axis (PEC) in the documentation for the "Post processing analysis advanced >> PECs" has units of [ph cm^-3 s^-1], whereas the use of the .plot_pec_sticks([0],[0],[0]) has axis label [ph cm^-1 s^-1].

Documentation: image

Function (.plot_pec_sticks([0],[0],[0])): image

johnson-c commented 1 week ago

The units of PEC should be ph cm^3 s^{-1}. Makes sense when you think I =n_en_zPEC [ph cm^{-3} s^{-1}]. There is a typo in the ColRadPy paper unfortunately "cm^{-3}" and I guess also in the documentation. Good catch, if you change the units to cm^3 I will merge that request. Thanks.