search

johnstonskj / rust-atelier

Rust native core model for the AWS Smithy IDL
MIT License
77 stars 11 forks source link

fix for bug #31, new unit test, and fix motd+weather line-oriented tests #33

Closed stevelr closed 3 years ago

stevelr commented 3 years ago

Fixed the operation bug described in bug #31, and added a unit test to confirm the fix. This fix caused some line-oriented tests (motd and weather) to fail because they had captured incorrect output due to the bug. I patched the result files so that they are correct and all tests pass.

stevelr commented 3 years ago

Hi Simon, - the reason I fixed the line tests in this PR is because this repo's github hooks prevent checkin if any tests fail. I can hack around that if you'd prefer that this PR doesn't include test changes and only includes the bug fix.

The bug is blocking me from publishing a crate (a rust code generator), because I have a git branch as a dependency. Please let me know if there's anything I can do to help. Thanks.

johnstonskj commented 3 years ago

Thanks!

johnstonskj commented 3 years ago

Done, merged and included in atelier_core 0.2.22

On Fri, Jul 2, 2021 at 9:04 AM stevelr @.***> wrote:

Hi Simon, - the reason I fixed the line tests in this PR is because this repo's github hooks prevent checkin if any tests fail. I can hack around that if you'd prefer that this PR doesn't include test changes and only includes the bug fix.

The bug is blocking me from publishing a crate (a rust code generator), because I have a git branch as a dependency. Please let me know if there's anything I can do to help. Thanks.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/johnstonskj/rust-atelier/pull/33#issuecomment-873103832, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIGRRZGJHMEA4XQPZWSFN3TVXPQJANCNFSM47OUN6TQ .