search

johnsusek / praeco

Elasticsearch alerting made simple.
GNU General Public License v3.0
549 stars 88 forks source link

Use Time Window - drop if #531

Closed IlliciteS closed 1 year ago

IlliciteS commented 1 year ago

Hello,

We've been using Praceo for a while but we have some troubles to understand the meaning of that feature.

What do you mean by drop if? It could mean two opposite things, for me, as a non native English speaker: trigger or cancel, which is pretty problematic. image

For instance, in that case, the alarm will trigger only if we are inside the 1pm - 0h00, right? Thanks for any explanations.

nsano-rururu commented 1 year ago

English is not my native language either.

https://github.com/johnsusek/elastalert-server/pull/6 https://github.com/johnsusek/praeco/pull/301

nsano-rururu commented 1 year ago

A pull request if you'd prefer a better word

IlliciteS commented 1 year ago

Sorry, I'm a bit late bit what does it still mean? Pull request = does it trigger the alarm inside a range or does it cancel it?

nsano-rururu commented 1 year ago

I will change the wording you want to change, so please make a pull request. Is that okay?

IlliciteS commented 1 year ago

I tried. I git clone, I did the changes, and try tio push my new branch so that I can do a pull request but I am not allowed to push the new branch.

nsano-rururu commented 1 year ago

https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens