johnsusek / praeco

Elasticsearch alerting made simple.
GNU General Public License v3.0
549 stars 88 forks source link

Javascript errors when trying to activate 'alerta' as destination #532

Closed poffyna closed 1 year ago

poffyna commented 1 year ago

🐛 Describe the bug

praecoapp/praeco:1.8.13 praecoapp/elastalert-server:20230402

👀 Steps to reproduce

All other destinations can be activated without errors. We have been using Praeco for some time now with mainly RocketChat as destination, and we are pleased with this. But we want to add Alerta as additional destination, which fails.

🆗 Expected behavior

Environments

Both elastalert-server and praeco run in docker containers.

Additional context

nsano-rururu commented 1 year ago

@poffyna Thank you for using the alert notification function to Rocket.Chat. I added the alert notification function to Rocket.Chat to elastalert2. One of the maintainers of elastalert2. I'll look into the praeco bug over the weekend. I'll release a new version over the weekend if it looks like it will be ready soon.

nsano-rururu commented 1 year ago

Fix https://github.com/johnsusek/praeco/commit/c5171011e68adb6adb023ea7798f433d60705dc2

nsano-rururu commented 1 year ago

@poffyna Fixed version 1.8.14 has been released. https://hub.docker.com/r/praecoapp/praeco/tags

poffyna commented 1 year ago

Thank you for the quick action. I have downloaded and started the 'latest' docker containers, which indeed show the new version: image

However... the issue is still there: javascript/vue errors popping up as soon as I click the 'Alerta' destination . And same issue when going to the Alerta tab and filling/updating any of the values there.

nsano-rururu commented 1 year ago

@poffyna Fixed version 1.8.15 has been released. https://hub.docker.com/r/praecoapp/praeco/tags

poffyna commented 1 year ago

@nsano-rururu Version 1.8.15 indeed solves the javascript errors. Thanks!