johnsusek / praeco

Elasticsearch alerting made simple.
GNU General Public License v3.0
549 stars 88 forks source link

Alerta tab: change API_URL field to non-mandatory #535

Closed poffyna closed 1 year ago

poffyna commented 1 year ago

🎉 Goal

As the alerta_api_url can be populated via the BaseRule.config file, it should not be mandatory in each rule. I would prefer to maintain the url on a single place.

💪 Motivation

Adding the url to each rule is cumbersome.

📖 Reference (optional)

📆 Schedule (optional)

📎 Tasks (optional)

nsano-rururu commented 1 year ago

I don't use praeco, so I hope someone who does will send me a pull request for additional features.

poffyna commented 1 year ago

I tried my first github pull request ever... I hope this is what you need? https://github.com/poffyna/praeco/pull/1

nsano-rururu commented 1 year ago

That should probably be the only fix. I need to check the movement. . . Will it be maintained in a forked repository? . Good luck.

nsano-rururu commented 1 year ago

https://github.com/johnsusek/praeco/commit/23fa7804be3fb7c197c48e20bf019397854482d3

poffyna commented 1 year ago

Will it be maintained in a forked repository? . Good luck.

This was my first pull request ever... looks like I made it on the wrong repo. I have no intention to maintain a forked repo.

poffyna commented 1 year ago

@nsano-rururu Will your 23fa780 update become available in a next release?

nsano-rururu commented 1 year ago

@nsano-rururu Will your 23fa780 update become available in a next release?

Will be available in next version.

nsano-rururu commented 1 year ago

1.8.16 release