search

johnthagen / clion-cppcheck

:ballot_box_with_check: cppcheck plugin for CLion
https://plugins.jetbrains.com/plugin/8143-cppcheck/
MIT License
31 stars 6 forks source link

fixed some issues with potentially non-existent files #56

Closed firewave closed 3 years ago

firewave commented 3 years ago

The temporary file name conflict issue can happen if you have two files with the same name or (more likely) when the plugin is flooded with duplicated check requests during batch scanning.

firewave commented 3 years ago

Is this fine to merge? I still have a couple of smaller changes. After those are in we could do a 1.6.0 release. Have been using it for the past weeks weeks in production and it works fine.

johnthagen commented 3 years ago

@firewave Yes please feel to merge changes as you see fit.

firewave commented 3 years ago

@firewave Yes please feel to merge changes as you see fit.

@johnthagen Alright. Will still go through the PRs for this round of changes - after 1.6.0 I will move on to directly pushing to the master/main if that is okay.

johnthagen commented 3 years ago

I will move on to directly pushing to the master/main if that is okay.

Yes, feel free to work as you see fit. One nice thing about PRs is they are easy to squash to keep the history clean, but feel free to do how you'd like.

firewave commented 3 years ago

Yes, feel free to work as you see fit. One nice thing about PRs is they are easy to squash to keep the history clean, but feel free to do how you'd like.

Thanks! I usually don't squash since when I am done with coding I try to put my work into separate commits to make it easier to review as well as bisecting issues.