added missing com.intellij.modules.java dependency / 1.6.4 release / bumped to 1.6.5

johnthagen / clion-cppcheck

:ballot_box_with_check: cppcheck plugin for CLion

https://plugins.jetbrains.com/plugin/8143-cppcheck/

MIT License

31 stars 6 forks source link

added missing com.intellij.modules.java dependency / 1.6.4 release / bumped to 1.6.5 #95

Closed firewave closed 10 months ago

johnthagen commented 11 months ago

I would recommend adding "Closes #70" to the PR description so that it will close that issue automatically on merge.

firewave commented 11 months ago

I would recommend adding "Closes #70" to the PR description so that it will close that issue automatically on merge.

That is already in the commit message.

johnthagen commented 10 months ago

@firewave 1.6.4 has been uploaded to JetBrains for moderation.

Thanks again for your work!

firewave commented 10 months ago

No problem. Let's hope it goes through this time.

The really big tasks are still to come ... 😫

johnthagen commented 10 months ago

1.6.4 has been approved and released. 🚀

firewave commented 10 months ago

Something is wrong here:

It is not compatible with several IDEs including CLion.

And I once again forgot the newline in the release notes:

johnthagen commented 10 months ago

Perhaps the way compatibility is declared had changed?

https://github.com/johnthagen/clion-cppcheck/blob/10341182f5760d92f6200b67cb5de9ceb5ff6d90/resources/META-INF/plugin.xml#L30

firewave commented 10 months ago

Unlikely as that is the version of the underlying platform. I have the feeling it might be related to the added com.intellij.modules.java dependency.

I will do some local tests later on and contact the support if necessary.

johnthagen commented 10 months ago

Yes, I can confirm that is it:

Since that compatibility issue only dealt with 2019.x, why don't we simply bump our minimum idea-version to the corresponding build version for 2020.x and revert the dependency we added in this PR? We could probably go even higher given that it's unlikely many users will be using anything older than 2022.x.