search

johntruckenbrodt / pyroSAR

framework for large-scale SAR satellite data processing
MIT License
511 stars 112 forks source link

all responses should raise exception on HTTP error #180

Closed jkeifer closed 2 years ago

jkeifer commented 2 years ago

I ran into an issue where some scihub maintenance appeared to cause corrupt S1 orbit files to be written to disk. Investigating the problem, I believe the root cause is in most cases the response of HTTP requests is not checked, thus even when an HTTP error is returned by the server the response is still used, despite being invalid.

This PR ensures each place where an HTTP request is made that an exception will be raised if an HTTP error is encountered, rather than silently proceeding.

Please let me know if there are any concerns about this change.

johntruckenbrodt commented 2 years ago

Hi @jkeifer. Thanks a lot. Looks good to me. Never mind the failing CI tests, there were some other issues.

jkeifer commented 2 years ago

Thanks!