`archive.insert` wrongly registers scenes as duplicate because of non-unique `ID.outname_base`

johntruckenbrodt / pyroSAR

framework for large-scale SAR satellite data processing

MIT License

498 stars 110 forks source link

`archive.insert` wrongly registers scenes as duplicate because of non-unique `ID.outname_base` #251

Closed maawoo closed 1 year ago

maawoo commented 1 year ago

archive.insert relies on ID.outname_base to register scenes regularly or as duplicates. In the following example GRDs and SLCs are inserted into a new archive, however due to the non-unique outname_base, the SLC is not inserted regularly:

maawoo commented 1 year ago

A solution could be to include self.product in outname_base, e.g.: S1B__SLC_IW___A_20211114T190431. Not sure if there is another way around this problem.

johntruckenbrodt commented 1 year ago

You've caught a big one @maawoo. the method outname_base is an old one that is deep in the DNA of pyroSAR. Adding the product definitely needs to be done (too bad I didn't back when I wrote it). However, since this method is used in so many places this needs to be done with great care so that nothing gets broken along the way. I am not sure I will get to it this month.