johnw42 / fira-code-emacs

Some code to make Fira Code work in Emacs
Apache License 2.0
60 stars 4 forks source link

Making things work with Doom Emacs #8

Open johnhamelink opened 4 years ago

johnhamelink commented 4 years ago

Caution: Developer with no lisp experience coming in hot with probably incorrect yet well-intentioned thoughts

I had to remove the (load "fira-code-data") line from fira-code.el and load the files from my config.org like so:

  (load-file "/home/john/.config/doom/font-ligatures/ligature-font.el")
  (load-file "/home/john/.config/doom/font-ligatures/fira-code-data.el")
  (load-file "/home/john/.config/doom/font-ligatures/fira-code.el")

While I was there, I fixed some warnings on lines 72-80 (replacing t with _):

    (cond
     ;; Haskell-specific settings:
     ((derived-mode-p 'haskell-mode)
      (pcase input-string
        ("$" _)                         ; use alternate $
        ("/=" "!=")                     ; "not equal" is /=
        ("!=" nil)                      ; != is not special
        (_ default-enabled)))
     (_ default-enabled))))

After that, it works as expected, from what I can tell. Thanks for contributing this project :)

oktoze commented 3 years ago

Thank you, this was helpful!