johnwalley / bumps-results

Cambridge and Oxford Bumps results
Creative Commons Attribution 4.0 International
4 stars 1 forks source link

How to handle cancelled divisions #11

Open mcshane-fire opened 1 year ago

mcshane-fire commented 1 year ago

In 2023 Lents some of the divisions were cancelled, with the result that some divisions completed their first three races, other their first two, and other the first two and the last race.

My format already had support for a 't' code which means terminate that division. It didn't quite handle the lents 2023 scenario, but I've changed my parsing code so that results that follow a 't' go to the correct place. With a little tinkering to show light grey line if there a split between results, this shows what I render from the results file.

lents2023_women

lents2023_women.txt

Is this a good suggestion of how these types of events should be handled?

johnwalley commented 1 year ago

Oh, that looks like a nice way to handle it.

I'm a bit rusty on the meaning of t. Does the following describe the new situation?

  1. t by itself -> division cancelled
  2. Normal results followed by t -> remaining crews rowed over
mcshane-fire commented 1 year ago

I think originally t meant number 2 on your list, and possibly number 1. I'm thinking that number 2 is just a bit lazy and not very useful (and potentially confusing), so I'm suggesting it's only allowed as option 1 (so it must be the first result for a new division).

mcshane-fire commented 1 year ago

Having said that, the parsing code I checked in https://github.com/mcshane-fire/bumps/blob/master/src/bumps.py allows for both of your suggestions.
1) If none of the crews in that division have a results code and we see a 't' then that division is shown as not racing. 2) If there has been at least one other result code for that division before the 't' then I assume the whole division raced (with crews yet to have results rowing over).

In the results files that I'm generating I don't rely on that second use case, but the description of this result code in https://github.com/mcshane-fire/bumps/blob/master/readme.txt does implicitly allow both use cases.