Open johnwdubois opened 3 years ago
We'll be using the term "Audio BookMark" instead
@johnwdubois We've got this feature working with prototypical UI, though there are a few changes in the design we'd like your feedback on:
1) The AudioBookmarkTime
is created by the Enter key when Audio is not playing, instead of the Spacebar. The reasoning here is to have Spacebar only pause and play Audio, while Enter is the key used for placing the AudioBookmarkTime
Hopefully this will prevent the user from accidentally placing bookmarks and make the different keys' functionality more intuitive.
2) The bookmark created (by the Enter key) while Audio is not playing is designated by the User's current Focus Line (AKA the top line), instead of the unit their cursor is hovering over. This prevents edge cases of the mouse not being over a unit, and is also hopefully more intuitive.
@johnwdubois With the UI more polished, the feature is complete. Now we just need to user test.
The Spacebar and Enter key functions have been user tested and performs well.
Background The Spacebar and ENTER key are both useful for controlling audio playback, but they should have slightly different functions.
Describe the solution you'd like
Spacebar function The Spacebar retains the user’s current location as an “audio landmark” or reference point.
AudioLandmarkTime
based on the UnitStart time for this Unit.AudioLandmarkTime
(e.g. from the UnitStart time for the current Unit)AudioLandmarkTime
).ENTER key function The ENTER key resets the user’s location, creating a new “audio landmark” as a reference point.
AudioLandmarkTime
to the place it stopped.)AudioLandmarkTime
), but does not reset.Additional context See also #112 , #116, and #114.