search

johnwmillr / LyricsGenius

Download song lyrics and metadata from Genius.com 🎶🎤
http://www.johnwmillr.com/scraping-genius-lyrics/
MIT License
898 stars 159 forks source link

Added utf-8 encoding when saving a file #104

Closed CrazyCrud closed 5 years ago

CrazyCrud commented 5 years ago

Specifying a custom file name in order to save a song can produce an error when the name contains umlauts. Using "utf-8" as file encoding fixes the error.

johnwmillr commented 5 years ago

Hey @CrazyCrud, could you give me some examples of songs that fail? I'm not able to recreate an error with umlauts. It'd be even better if you could write some example tests that fail unless your code modifications are in place.

CrazyCrud commented 5 years ago

Hey @johnwmillr, I tried to replicate the error but everything went fine. The error that occurred had probably other reasons I wasn't aware of. Nonetheless, thank you for your time! I'll close the request.

johnwmillr commented 5 years ago

Glad to hear it's working for you!