search

johnwmillr / LyricsGenius

Download song lyrics and metadata from Genius.com 🎶🎤
http://www.johnwmillr.com/scraping-genius-lyrics/
MIT License
898 stars 159 forks source link

Feature/119 artist features #124

Closed danielcliu closed 4 years ago

danielcliu commented 4 years ago

Expands the library's functionality by letting users requests artist objects include songs where said artist is not the primary artist. Accomplished by adding a boolean argument to search_artist(), which is then passed down to add_song().

Also added a test to cover this code.

johnwmillr commented 4 years ago

Hi Daniel,

Thanks for the PR. When I run your code the test_search_song test fails. Can you repeat this error and fix it?

I'd also like if the include_features flag was more restrictive than allowing all artist names. Can you add some sort of conditional that checks for "feat", "featuring", "ft.", etc. in the song name?

John

danielcliu commented 4 years ago

Bump

johnwmillr commented 4 years ago

Thanks for this PR, @danielcliu! I'll merge it to master now.