search

johnwmillr / LyricsGenius

Download song lyrics and metadata from Genius.com 🎶🎤
http://www.johnwmillr.com/scraping-genius-lyrics/
MIT License
898 stars 159 forks source link

search_artist() hangs on some songs. #133

Closed ChairMane closed 4 years ago

ChairMane commented 4 years ago

Describe the bug I called this: artist = genius.Genius.search_artist('Sia', max_songs=30) and I get to around 18 songs, and the program hangs without retrieving new songs.

Expected behavior I expected to get 30 songs, with the Done! message returned. I only got 18 songs. EDIT Search finally ended when in a try/except block. After the 18th song, it failed. To Reproduce Describe the steps required to reproduce the behavior.

  1. gen = genius.Genius(genius_client_token['genius_token'], timeout=3, remove_section_headers=True, excluded_terms=['(Remix)', '(Live)'])
  2. artist = gen.search_artist('Sia', max_songs=30)

Include the error message associated with the bug.

Version info

Additional context When trying to find songs for other artists, the program hangs on earlier songs. For example, for Sia, it hangs around 24 songs when skipping certain songs. When searching for Devin Townsend, the program hang at 3 songs.

ChairMane commented 4 years ago

So, I changed the timeout parameter to 3 seconds instead, and it finally got all the way through.