Closed allerter closed 3 years ago
Hi @Allerter, I'm getting an AttributeError: 'Tee' object has no attribute 'encoding'
error on the test_saving_json_file
and test_saving_txt_file
. Is this related to the VCR package? Are you getting the same error on your end?
Hi. I ran all the tests and all of them passed successfully.
The PR is ready to go. All tests are passing locally for me. Thank you for your hard work on this, @Allerter.
Should we update the package version to 3.0.0?
The tests passed on Travis CI too. I think we're ready to go.
I forgot to update the release notes in the docs and on GitHub's Releases page. Please merge this PR after I commit the release notes.
Happy to contribute, @johnwmillr.
I added the release notes but put question marks instead of the release day (2021-02-??
). Please replace that when you release the new version.
3.0.0 is live on PyPi!
types
attributes using the information in docstrings but they looked a bit messy. So I removed them and manually put them in a table in docsalbum.songs
toalbum.tracks
Track
type (Note: On Genius a track just has thenumber
andsong
attributes, but sinceTrack
inheritsBaseEntity
it will have a redundantid
attribute andTrack.id == Track.song.id
.)