v3.0 - Githubissues

johnwmillr / LyricsGenius

Download song lyrics and metadata from Genius.com 🎶🎤

http://www.johnwmillr.com/scraping-genius-lyrics/

MIT License

892 stars 158 forks source link

v3.0 #171

Closed allerter closed 3 years ago

allerter commented 3 years ago

Sphinx displayed types attributes using the information in docstrings but they looked a bit messy. So I removed them and manually put them in a table in docs
added checking for song_info['instrumental'] when available to avoid fetching lyrics for instrumental songs.
renamed album.songs to album.tracks
added the Track type (Note: On Genius a track just has the number and song attributes, but since Track inherits BaseEntity it will have a redundant id attribute and Track.id == Track.song.id.)
refactored OAuth2 to only support code flow in get_user_token since the token flow already has the token in the redirected url.
added release notes to docs (not completed yet)

allerter commented 3 years ago

[x] Ready to be merged

johnwmillr commented 3 years ago

Hi @Allerter, I'm getting an AttributeError: 'Tee' object has no attribute 'encoding' error on the test_saving_json_file and test_saving_txt_file. Is this related to the VCR package? Are you getting the same error on your end?

allerter commented 3 years ago

Hi. I ran all the tests and all of them passed successfully.

johnwmillr commented 3 years ago

The PR is ready to go. All tests are passing locally for me. Thank you for your hard work on this, @Allerter.

Should we update the package version to 3.0.0?

allerter commented 3 years ago

The tests passed on Travis CI too. I think we're ready to go.

allerter commented 3 years ago

I forgot to update the release notes in the docs and on GitHub's Releases page. Please merge this PR after I commit the release notes.

allerter commented 3 years ago

Happy to contribute, @johnwmillr. I added the release notes but put question marks instead of the release day (2021-02-??). Please replace that when you release the new version.

johnwmillr commented 3 years ago

3.0.0 is live on PyPi!