johnwmillr / LyricsGenius

Download song lyrics and metadata from Genius.com 🎶🎤
http://www.johnwmillr.com/scraping-genius-lyrics/
MIT License
878 stars 159 forks source link

Improved PublicAPI.page_data #209

Open allerter opened 3 years ago

allerter commented 3 years ago

The ‍‍‍‍PublicAPI.page_data method needed the artist and the song's slug to get the page data for a song. But as it turns out, it can also be done using the song ID which is both easier and more reliable. I tried, but couldn't do the same for albums. Although it seems that the album parameter is reliable for albums.

This PR breaks backward compatibility. We can either wait till v4 to merge it or I can make it backward compatible by adding the song and artist back.