johnwmillr / LyricsGenius

Download song lyrics and metadata from Genius.com 🎶🎤
http://www.johnwmillr.com/scraping-genius-lyrics/
MIT License
904 stars 159 forks source link

Reduce Verbosity #256

Open kmaurinjones opened 1 year ago

kmaurinjones commented 1 year ago

Is your feature request related to a problem? Please describe. Love the library! It's been very useful for a lyric analysis project I'm working on, but since I'm getting lyrics for all artists at a time (some of which have hundreds of songs), I'm getting enormous and verbose printouts that can exceed 1000 lines of text.

Describe the solution you'd like It would be amazing if there could be a "verbose = False" argument (or something equivalent) added to each retrieval method (I'm currently using .search_song(), to avoid this.

Describe alternatives you've considered While the most ideal solution is what I've put above (this way I can write my own progress-printing statement, or have nothing at all if I want), I would settle for a simple printed statement that lists the numerical id of a song in relation to the total number being retrieved, that simply is re-written over the same line. Something like: print(f"Song {song_num_id} of {len(all_songs)}", end = '\r')

allerter commented 1 year ago

That's certainly a good idea, but we'll probably introduce the logging module to the library and remove the verbose argument altogether (#185). That way we will have total control over the output.