search

johnwmillr / LyricsGenius

Download song lyrics and metadata from Genius.com 🎶🎤
http://www.johnwmillr.com/scraping-genius-lyrics/
MIT License
899 stars 159 forks source link

support save titles with dots #65

Closed eavelardev closed 5 years ago

eavelardev commented 5 years ago

There are titles of songs that contain dots, for example Mr. Brightside of The Killers and filename.split ('.') [0] takes only 'Mr'

johnwmillr commented 5 years ago

Good catch! This is certainly a logic error on my point. I will suggest a couple changes to your PR, because I'd still like to handle the cases where users do or don't supply a file extension.

johnwmillr commented 5 years ago

Sorry for taking so long to get to this PR. I added a couple commits that cleans up the formatting on file extensions, but keeps your change. I also added your change (and my cleanups) to the artist.py file. Thanks for the PR!