johnwmillr / LyricsGenius

Download song lyrics and metadata from Genius.com 🎶🎤
http://www.johnwmillr.com/scraping-genius-lyrics/
MIT License
899 stars 159 forks source link

search_artist should use Genius's the list songs endpoint from the artist's page #68

Closed johnwmillr closed 5 years ago

johnwmillr commented 5 years ago

Is your feature request related to a problem? Please describe. The current Genius.search_artist method relies on a heuristic for finding song's by the requested artist. This method is slow, inefficient, and may miss songs that belong to the artist.

Describe the solution you'd like Use the same endpoint Genius.com uses when listing songs on an artist's page.

Here is an example of the all songs endpoint for Jay-Z:

Additional context Not sure if this API endpoint is publicly listed by Genius, but the endpoint returns a 200 when I make a request to it.

johnwmillr commented 5 years ago

Oh, I'm already doing this and the endpoint is supported by Genius.

Closing issue.