Closed TwistedAsylumMC closed 5 years ago
Ah, thanks for catching this bug! I think the fix is as changing self.artist
to self.name
. I'll try to make the fix and update the code tonight.
Hopefully that small change fixes the bug! I had written a test for Artist.save_lyrics
, but the test supplies a filename to the function; this bug only shows up when the user doesn't pass a filename in.
Hi, something appears being off still. Minimal script is failing:
import lyricsgenius as genius access_token = 'XXXX' api = genius.Genius(access_token) artist = api.search_artist("The Beatles", max_songs=3) artist.savelyrics(format='json', filename='out.json')
.\python\lyrics>py -3 ./genius.py Searching for songs by The Beatles...
Song 1: "12-Bar Original" Song 2: "1822!" "1 [Booklet]" is not valid. Skipping. "20 Greatest Hits - Art and Tracklist" is not valid. Skipping. Song 3: ""Abbey Road" side two"
Reached user-specified song limit (3).
Done. Found 3 songs.
Traceback (most recent call last):
File "./genius.py", line 19, in
.\python\lyrics>py -3 --version Python 3.6.2
Shoot, okay. I'll try to take another look in the next couple of days. Thanks for following up.
@robot3498712 hopefully #75 fixes this bug for you. I was using a sloppy method of accessing elements within the Song object's self._body dictionary, causing an error when the requested field wasn't present in the dict. Let me know if you do run into any more bugs!
@johnwmillr Thank you, I can confirm issue is fixed. Cheers!
Describe the bug Using the code
artist.save_lyrics()
I am given an error when running the scriptExpected behavior I expected the lyrics of a chosen song to be saved to a file
To Reproduce Describe the steps required to reproduce the behavior. Use the following code:
Include the error message associated with the bug.
Version info
Additional context Add any other context about the problem here.