johnxnguyen / Down

Blazing fast Markdown / CommonMark rendering in Swift, built upon cmark.

Other

2.24k stars 320 forks source link

[Fix] Compilation failure with Xcode 12.5 and SPM #245

Closed claurel closed 3 years ago

claurel commented 3 years ago

After updating to Xcode 12.5, the Down framework no longer builds (at least when used through the Swift Package Manager.) The compiler error message is:

Unknown type name 'cmark_reference_map' inlines.h

Including the file references.h in inlines.h fixes the problem. This is a quick and dirty fix. Ideally, it shouldn't be necessary to modify the CommonMark code to fix this.

codecov-io commented 3 years ago

Codecov Report

Merging #245 (3b15227) into master (cbe21ad) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   68.73%   68.73%           
=======================================
  Files          75       75           
  Lines        2050     2050           
=======================================
  Hits         1409     1409           
  Misses        641      641

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cbe21ad...3b15227. Read the comment docs.

claurel commented 3 years ago

Great, I'm glad it was useful! And thanks for developing and maintaining Down. I'm the main developer of the iOS app Sky Guide, and we're switching to Down from another markdown framework that wasn't getting any updates.

Best regards,

—Chris

On Fri, Feb 12, 2021 at 11:34 AM John Nguyen notifications@github.com wrote:

@johnxnguyen approved this pull request.

Hi @claurel https://github.com/claurel , thanks for the contribution. I'm happy to accept a temporary solution and will take some time to investigate what's going wrong. I'm looking into making the framework more SPM friendly so this quick workaround buys me a little time. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/johnxnguyen/Down/pull/245#pullrequestreview-589779936, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMY7YRHNJAKP3UISISEVNTS6V7EHANCNFSM4XPSU7BA .

johnxnguyen commented 3 years ago

@claurel I'm happy to hear it. It's been a little while since there has been some updates here but I have do some plans for Down. Feel free to reach out again in the future!