Closed johnxnguyen closed 3 years ago
Merging #251 (7d7de50) into master (3ac921e) will increase coverage by
52.90%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #251 +/- ##
===========================================
+ Coverage 38.41% 91.32% +52.90%
===========================================
Files 80 60 -20
Lines 2262 1037 -1225
===========================================
+ Hits 869 947 +78
+ Misses 1393 90 -1303
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3ac921e...7d7de50. Read the comment docs.
What's in this PR?
Fixes: https://github.com/johnxnguyen/Down/issues/205
Issue
Codecov is reporting a much lower coverage than actually exists.
Cause
This appears to be to two main reasons:
Solution
Also, to keep things simple, I've decided to move the snapshot tests into the main test test target and run them only for iOS.