search

johnxnguyen / Down

Blazing fast Markdown / CommonMark rendering in Swift, built upon cmark.
Other
2.24k stars 319 forks source link

RTL support in lists #261

Closed foxware00 closed 3 years ago

foxware00 commented 3 years ago
codecov[bot] commented 3 years ago

Codecov Report

Merging #261 (f66490e) into master (e2b597d) will decrease coverage by 1.14%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
- Coverage   92.47%   91.32%   -1.15%     
==========================================
  Files          60       60              
  Lines        1023     1061      +38     
==========================================
+ Hits          946      969      +23     
- Misses         77       92      +15
Impacted Files Coverage Δ
.../AST/Styling/Helpers/ListItemParagraphStyler.swift 100.00% <100.00%> (ø)
...ces/Down/AST/Styling/Options/ListItemOptions.swift 100.00% <100.00%> (ø)
...ST/Styling/Layout Managers/DownLayoutManager.swift 90.74% <0.00%> (-5.34%) :arrow_down:
...ces/Down/AST/Styling/Text Views/DownTextView.swift 38.70% <0.00%> (-4.15%) :arrow_down:
Sources/Down/Views/DownView.swift 82.82% <0.00%> (-1.90%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2b597d...f66490e. Read the comment docs.

foxware00 commented 3 years ago

@johnxnguyen I don't suppose you've had a chance to look at this?

foxware00 commented 3 years ago

Hi @foxware00 , I'm starting to catch up on the backlog here so apologies for the delay. Looks good to me, thanks for the contribution!

No problem at all, I was just doing some housekeeping on some stale PR's. Many thanks!