search

johnynek / bosatsu

A python-ish pure and total functional programming language
Apache License 2.0
224 stars 11 forks source link

Allow more than one parameter group on def #1037

Closed johnynek closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 98.41% and project coverage change: -0.01% :warning:

Comparison is base (1b3dcdf) 91.75% compared to head (fda3edd) 91.75%. Report is 4 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1037 +/- ## ========================================== - Coverage 91.75% 91.75% -0.01% ========================================== Files 91 91 Lines 9460 9479 +19 Branches 2208 2197 -11 ========================================== + Hits 8680 8697 +17 - Misses 780 782 +2 ``` | [Files Changed](https://app.codecov.io/gh/johnynek/bosatsu/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=P.+Oscar+Boykin) | Coverage Δ | | |---|---|---| | [...ain/scala/org/bykn/bosatsu/DefRecursionCheck.scala](https://app.codecov.io/gh/johnynek/bosatsu/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=P.+Oscar+Boykin#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYnlrbi9ib3NhdHN1L0RlZlJlY3Vyc2lvbkNoZWNrLnNjYWxh) | `97.61% <97.50%> (+0.21%)` | :arrow_up: | | [.../src/main/scala/org/bykn/bosatsu/Declaration.scala](https://app.codecov.io/gh/johnynek/bosatsu/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=P.+Oscar+Boykin#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYnlrbi9ib3NhdHN1L0RlY2xhcmF0aW9uLnNjYWxh) | `98.91% <100.00%> (ø)` | | | [...src/main/scala/org/bykn/bosatsu/DefStatement.scala](https://app.codecov.io/gh/johnynek/bosatsu/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=P.+Oscar+Boykin#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYnlrbi9ib3NhdHN1L0RlZlN0YXRlbWVudC5zY2FsYQ==) | `100.00% <100.00%> (ø)` | | | [.../main/scala/org/bykn/bosatsu/SourceConverter.scala](https://app.codecov.io/gh/johnynek/bosatsu/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=P.+Oscar+Boykin#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYnlrbi9ib3NhdHN1L1NvdXJjZUNvbnZlcnRlci5zY2FsYQ==) | `97.56% <100.00%> (+0.01%)` | :arrow_up: | | [...re/src/main/scala/org/bykn/bosatsu/Statement.scala](https://app.codecov.io/gh/johnynek/bosatsu/pull/1037?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=P.+Oscar+Boykin#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYnlrbi9ib3NhdHN1L1N0YXRlbWVudC5zY2FsYQ==) | `98.75% <100.00%> (ø)` | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/johnynek/bosatsu/pull/1037/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=P.+Oscar+Boykin)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

johnynek commented 1 year ago

related to #1026 -- with automatic currying, this syntax is superfluous, but with explicit function sizes, then it is useful when you have cases that will almost always be curried (like building comparison or equality functions from other functions).