codecov-commenter
commented
10 months ago Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.
Comparison is base (
ed5e2ff) 91.97% compared to head (9863beb) 92.22%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #1064 +/- ## ========================================== + Coverage 91.97% 92.22% +0.24% ========================================== Files 93 93 Lines 9881 9888 +7 Branches 2322 2335 +13 ========================================== + Hits 9088 9119 +31 + Misses 793 769 -24 ``` | [Files](https://app.codecov.io/gh/johnynek/bosatsu/pull/1064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=P.+Oscar+Boykin) | Coverage Δ | | |---|---|---| | [.../src/main/scala/org/bykn/bosatsu/rankn/Infer.scala](https://app.codecov.io/gh/johnynek/bosatsu/pull/1064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=P.+Oscar+Boykin#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYnlrbi9ib3NhdHN1L3JhbmtuL0luZmVyLnNjYWxh) | `96.87% <93.75%> (+0.04%)` | :arrow_up: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/johnynek/bosatsu/pull/1064/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=P.+Oscar+Boykin):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I don't think loops in the TyMeta graph actually cause a problem, but avoiding them isn't difficult, and makes things a bit simpler to reason about.