codecov-commenter
commented
9 months ago Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.
Comparison is base (
000a8a6) 92.02% compared to head (c4f1ee5) 92.09%. Report is 1 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #1067 +/- ## ========================================== + Coverage 92.02% 92.09% +0.07% ========================================== Files 93 93 Lines 9888 9903 +15 Branches 2335 2319 -16 ========================================== + Hits 9099 9120 +21 + Misses 789 783 -6 ``` | [Files](https://app.codecov.io/gh/johnynek/bosatsu/pull/1067?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=P.+Oscar+Boykin) | Coverage Δ | | |---|---|---| | [.../src/main/scala/org/bykn/bosatsu/rankn/Infer.scala](https://app.codecov.io/gh/johnynek/bosatsu/pull/1067?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=P.+Oscar+Boykin#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYnlrbi9ib3NhdHN1L3JhbmtuL0luZmVyLnNjYWxh) | `96.58% <97.05%> (-0.30%)` | :arrow_down: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/johnynek/bosatsu/pull/1067/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=P.+Oscar+Boykin):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is towards supporting existential types. Currently many functions are spreading out the handling of quantification by calling skolemize and unskolemize in two different places. This is trying to get them all collocated so we can add support for existential types more easily.
In any case it seems a good change, although the abstractions used are a bit heavier than I would like (use of FunctionK in scala isn't so elegant).