search

johnynek / bosatsu

A python-ish pure and total functional programming language
Apache License 2.0
223 stars 11 forks source link

Fix bug in kind checking of patterns #1073

Closed johnynek closed 8 months ago

johnynek commented 8 months ago

There were actually two bugs here:

  1. we were checking if either kind subsumed the other, which makes no sense.
  2. there was also a bug: Kind.leftSubsumesRight(kind2, kind2) which always returns true so the check was a no-op.

Fixing the bug exposed some issues with the super complexly typed RecordSet code.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e39f11a) 92.32% compared to head (e5076c4) 92.35%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1073 +/- ## ========================================== + Coverage 92.32% 92.35% +0.02% ========================================== Files 93 93 Lines 10277 10264 -13 Branches 2390 2391 +1 ========================================== - Hits 9488 9479 -9 + Misses 789 785 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.