Closed johnynek closed 7 months ago
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
a4db25d
) 92.42% compared to head (1dbc7d2
) 92.40%.
Files | Patch % | Lines |
---|---|---|
.../src/main/scala/org/bykn/bosatsu/rankn/Infer.scala | 77.77% | 2 Missing :warning: |
...e/src/main/scala/org/bykn/bosatsu/rankn/Type.scala | 96.66% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is an invariant I realized we were losing. since
(forall x. C[x])[y] == (forall x. C[x, y])
we can always push formal out of TyApply and keep the left hand side a Rho type.This makes it easier to reason about the types, but also does a minor performance improvement in Infer since we can leverage that the left is a Rho without having to pattern match again.